Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build executable sdk implementation #250

Merged
merged 4 commits into from
Aug 24, 2023
Merged

Conversation

claire1618
Copy link
Contributor

No description provided.

@claire1618 claire1618 requested a review from a team as a code owner August 23, 2023 19:44
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #250 (933834d) into main (9678a2f) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
+ Coverage   91.15%   91.22%   +0.06%     
==========================================
  Files          19       19              
  Lines        1425     1436      +11     
==========================================
+ Hits         1299     1310      +11     
  Misses         92       92              
  Partials       34       34              
Files Changed Coverage Δ
vela/build.go 94.91% <100.00%> (+0.52%) ⬆️

Copy link
Contributor

@ecrupper ecrupper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit, otherwise looks good

vela/build.go Outdated
@@ -40,6 +40,20 @@ func (svc *BuildService) Get(org, repo string, build int) (*library.Build, *Resp
return v, resp, err
}

// Get returns the provided build executable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Get returns the provided build executable.
// GetBuildExecutable returns the executable for the provided build.

@wass3r wass3r changed the title feat:build executable sdk implementation feat: build executable sdk implementation Aug 24, 2023
@claire1618 claire1618 merged commit 0b0212b into main Aug 24, 2023
9 of 10 checks passed
@claire1618 claire1618 deleted the enhance/buildExecutable branch August 24, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants