Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: evaluate requires before compiled task #1962

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: evaluate requires before compiled task #1962

wants to merge 1 commit into from

Conversation

vmaerten
Copy link
Member

Fixes :

Two thing here :

  • The template should be evaluated (in CompiledTask) only after verifying the required variables.
  • skipFingerprint should not bypass the required variable checks.

@vmaerten vmaerten linked an issue Dec 15, 2024 that may be closed by this pull request
Template function breaks the "requires" feature #1950
Open
@vmaerten vmaerten marked this pull request as ready for review December 15, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pd93 pd93 Awaiting requested review from pd93

@andreynering andreynering Awaiting requested review from andreynering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Template function breaks the "requires" feature
1 participant
@vmaerten