Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce RegisterReaderHandlerWithEncoderInfo #1419

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jille
Copy link

@Jille Jille commented Apr 25, 2023

Description

Introduce RegisterReaderHandlerWithEncoderInfo

It is the same as RegisterReaderHandler, but receives some configuration
settings which are needed to correctly encode the TSV. (For now only the
Location).

for issue #1416

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

It is the same as RegisterReaderHandler, but receives some configuration
settings which are needed to correctly encode the TSV. (For now only the
Location).

issue go-sql-driver#1416
@Jille Jille changed the title Introduce RegisterReaderHandlerWithConfig Introduce RegisterReaderHandlerWithEncoderInfo Apr 26, 2023
@methane methane marked this pull request as draft May 27, 2023 17:09
@dolmen
Copy link
Contributor

dolmen commented Jun 2, 2023

You are not saying why the time.Location of the DSN is useful for encoding the TSV.

Some example code (ideally provided as a testable example) would be helpful for review as well as for end users.

@dolmen
Copy link
Contributor

dolmen commented Jun 2, 2023

See @methane comment in #1416 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants