Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add way to set empty header on request #496 #876

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

jeevatkm
Copy link
Member

@jeevatkm jeevatkm commented Oct 1, 2024

closes #496

The solution is not to use the method Get on the Header, which returns an empty string for a non-existing header key. Instead, check directly in the header map

@jeevatkm jeevatkm added this to the v3.0.0 Milestone milestone Oct 1, 2024
@jeevatkm jeevatkm self-assigned this Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.42%. Comparing base (c6cf259) to head (634b218).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #876      +/-   ##
==========================================
+ Coverage   98.15%   98.42%   +0.27%     
==========================================
  Files          14       14              
  Lines        2329     2414      +85     
==========================================
+ Hits         2286     2376      +90     
+ Misses         23       20       -3     
+ Partials       20       18       -2     
Flag Coverage Δ
unittests 98.42% <100.00%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeevatkm jeevatkm merged commit 9215e71 into main Oct 1, 2024
5 checks passed
@jeevatkm jeevatkm deleted the make-a-way-to-add-empty-header branch October 1, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant