Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Clone method for Request #847

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Conversation

tttturtle-russ
Copy link

Close #718

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.16%. Comparing base (82ae758) to head (411db15).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #847      +/-   ##
==========================================
+ Coverage   96.89%   97.16%   +0.26%     
==========================================
  Files          14       13       -1     
  Lines        1773     2078     +305     
==========================================
+ Hits         1718     2019     +301     
- Misses         35       39       +4     
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jeevatkm jeevatkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tttturtle-russ Thanks for creating a PR. Can you cover missing test case coverage?
See here - https://github.com/go-resty/resty/pull/847/checks?check_run_id=29887899895

@tttturtle-russ
Copy link
Author

I fixed it in commit 15f9912, it may need another coverage check.

@jeevatkm
Copy link
Member

@tttturtle-russ updated run see here - https://github.com/go-resty/resty/pull/847/checks?check_run_id=29962204508

Also, you could see the coverage on your local.
Run test

go test ./... -race -coverprofile=coverage.out -covermode=atomic -coverpkg=./...

See coverage HTML

go tool cover -html=coverage.out

@tttturtle-russ
Copy link
Author

@jeevatkm I have fixed the coverage problem.

@jeevatkm jeevatkm added feature v3 For resty v3 labels Sep 12, 2024
@jeevatkm jeevatkm added this to the v3.0.0 Milestone milestone Sep 12, 2024
Copy link
Member

@jeevatkm jeevatkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tttturtle-russ Thanks for the test coverage. Can you correct the bullet point formatting in the godoc?

It is not correctly displayed:
Screenshot 2024-09-12 at 7 57 41 AM

@tttturtle-russ
Copy link
Author

@jeevatkm Documentation looks fine now.
image

Copy link
Member

@jeevatkm jeevatkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tttturtle-russ Thanks for correcting godoc.

@jeevatkm jeevatkm merged commit f066c2e into go-resty:main Sep 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature v3 For resty v3
Development

Successfully merging this pull request may close these issues.

2 participants