-
Notifications
You must be signed in to change notification settings - Fork 711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Clone
method for Request
#847
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #847 +/- ##
==========================================
+ Coverage 96.89% 97.16% +0.26%
==========================================
Files 14 13 -1
Lines 1773 2078 +305
==========================================
+ Hits 1718 2019 +301
- Misses 35 39 +4
Partials 20 20 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tttturtle-russ Thanks for creating a PR. Can you cover missing test case coverage?
See here - https://github.com/go-resty/resty/pull/847/checks?check_run_id=29887899895
I fixed it in commit 15f9912, it may need another coverage check. |
@tttturtle-russ updated run see here - https://github.com/go-resty/resty/pull/847/checks?check_run_id=29962204508 Also, you could see the coverage on your local.
See coverage HTML
|
@jeevatkm I have fixed the coverage problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tttturtle-russ Thanks for the test coverage. Can you correct the bullet point formatting in the godoc?
@jeevatkm Documentation looks fine now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tttturtle-russ Thanks for correcting godoc.
Close #718