fix: buildCurlRequest() replace req.Body with req.GetBody() #844
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The `TestGenerateExecutedCurl` failure started after I merged from branch `v2` to branch `main`. It needs to investigate why it's failing.
Originally posted by @jeevatkm in #827 (comment)
Hi jeevatkm, I've found the reason why the test case failed.
In
resty/client.go
Line 1601 in 6d941ac
Do
method will read thereq.RawRequest.Body
and make it empty. When generating curl body it will read an empty string, and that's why it failed.This commit offers a temporary solution to this problem, I think the ultimate solution is to add a
Clone
method inRequest
, as #718 describes.