This repository was archived by the owner on Nov 28, 2024. It is now read-only.
Smtp client reset #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivy
reviewed
Dec 6, 2017
| timeout: false, | ||
| } | ||
|
|
||
| netDialTimeout = func(network, address string, d time.Duration) (net.Conn, error) { |
There was a problem hiding this comment.
Looking at the build error, the problem is here. If you capitalize NetDialTimeout that should fix it. (We exported this in #4).
|
@fjace05 Sorry, I accidentally closed this pull request while moving some things around. 😓 I'm going to integrate your changes in another branch soon. Thanks for your patience. |
|
Reopend this, cos we need it @ivy |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request to remedy Issue #77 from the base repo. It breaks out the already existent Reset method on the Go Lang net/smtp Client library. For this fix, the method is added to the SenderCloser interface to make it accessible when running the "Daemon Mode". This will allow users to reset the channel instead of completely closing and reopening the channel after an error occurs while sending a message.