Fix generating schema fails due to column name conflicts #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lumn name array and renames to {col}_ if it is a conflicting name. Added unit tests.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #418 +/- ##
=======================================
Coverage 90.46% 90.47%
=======================================
Files 132 132
Lines 7561 7566 +5
=======================================
+ Hits 6840 6845 +5
Misses 558 558
Partials 163 163 ☔ View full report in Codecov by Sentry. |
Neuman968
changed the title
Neuman968
changed the title
|
Thanks. Looks good. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #408
Added a function to rename a column if it conflicts with reserved keywords.
Updated sql_builder_template to check if column is in a conflict with reserved key words
Added unit tests.
Thank you for this awesome project! Let me know if there is anything I can add or change.