Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow GLFW_INVALID_VALUE at Init #325

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Allow GLFW_INVALID_VALUE at Init #325

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion v3.3/glfw/glfw.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,10 @@ const (
// This function may only be called from the main thread.
func Init() error {
C.glfwInit()
return acceptError(APIUnavailable)
// invalidValue can happen when specific joysticks are used. This issue
// will be fixed in GLFW 3.3.5. As a temporary fix, accept this error.
// See go-gl/glfw#292, go-gl/glfw#324, and glfw/glfw#1763.
return acceptError(APIUnavailable, invalidValue)
}

// Terminate destroys all remaining windows, frees any allocated resources and
Expand Down