Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comment header padding #33377

Merged
merged 5 commits into from
Jan 24, 2025
Merged

Fix comment header padding #33377

merged 5 commits into from
Jan 24, 2025

Conversation

typed-sigterm
Copy link
Contributor

I think it was a mistake.

Before:
image

After:
image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 24, 2025
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 24, 2025
@silverwind
Copy link
Member

silverwind commented Jan 24, 2025 •
edited
Loading

This will surely have unintended side effects all over the pages. I suggest instead to target this header specifically via Tailwind class py-0 in the HTML template.

@wxiaoguang
Copy link
Contributor

It should remove most incorrect classes and only keep comment-header

Before: ui top attached header comment-header tw-flex tw-items-center tw-justify-between

After:

image

@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Jan 24, 2025
@typed-sigterm
Copy link
Contributor Author

@silverwind @wxiaoguang done

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 24, 2025
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 24, 2025
@wxiaoguang
Copy link
Contributor

Made some new changes to fix more abuses:

image

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 24, 2025
silverwind
silverwind reviewed Jan 24, 2025
View reviewed changes
web_src/css/repo.css
position: relative;
color: var(--color-text);
min-height: 41px;
background-color: var(--color-box-header);
Copy link
Member

@silverwind silverwind Jan 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bg not needed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nvm, I see duplicate. Linter should have caught that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened stylelint/stylelint#8349 for the linter fyi.

@wxiaoguang wxiaoguang merged commit 9e028d8 into go-gitea:main Jan 24, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Jan 24, 2025
@typed-sigterm typed-sigterm deleted the patch-1 branch January 25, 2025 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@hiifong hiifong hiifong approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
5 participants
@typed-sigterm @silverwind @wxiaoguang @hiifong @GiteaBot