Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support disable passkey auth #33348

Merged
merged 11 commits into from
Jan 22, 2025
Merged

Support disable passkey auth #33348

merged 11 commits into from
Jan 22, 2025

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Jan 22, 2025

Fix #33314

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 22, 2025
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 22, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files docs-update-needed The document needs to be updated synchronously labels Jan 22, 2025
@yp05327 yp05327 added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files and removed modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Jan 22, 2025
@yp05327
Copy link
Contributor Author

yp05327 commented Jan 22, 2025

image
Why this is not allowed?

@lunny lunny added this to the 1.24.0 milestone Jan 22, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 22, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 22, 2025
@techknowlogick techknowlogick enabled auto-merge (squash) January 22, 2025 22:16
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 22, 2025
@techknowlogick techknowlogick merged commit a0b3d9a into go-gitea:main Jan 22, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 22, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 23, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
99da21b 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Support disable passkey auth (go-gitea#33348)
  Update JS dependencies (go-gitea#33359)
  Enable Typescript `noImplicitAny` (go-gitea#33322)
  Remove duplicate "ResponseWriter.Status" method (go-gitea#33346)
  Fix code button alignment (go-gitea#33345)
  [skip ci] Updated translations via Crowdin
  Support performance trace (go-gitea#32973)
  Make issue suggestion work for all editors (go-gitea#33340)
  Fix issue count (go-gitea#33338)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
docs-update-needed The document needs to be updated synchronously lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

passkey login persists after disabling login form
5 participants
@yp05327 @lunny @wxiaoguang @techknowlogick @GiteaBot