Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate "ResponseWriter.Status" method #33346

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Remove duplicate "ResponseWriter.Status" method #33346

merged 2 commits into from
Jan 22, 2025

Conversation

wxiaoguang
Copy link
Contributor

There were 2 functions in ResponseWriter: "Status" and "WrittenStatus", they are the same. So just keep one.

Why keep "WrittenStatus":

  • Two-word name is easier to search globally, and unlikely to conflict with other interfaces with Status method.
  • It has clearer meaning: just like WrittenSize (the size of response has been written).

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 22, 2025
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 22, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Jan 22, 2025
@wxiaoguang wxiaoguang added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. and removed modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Jan 22, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Jan 22, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Jan 22, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 22, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 22, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) January 22, 2025 06:13
@wxiaoguang wxiaoguang merged commit 6fe4d1c into go-gitea:main Jan 22, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the fix-written-status branch January 22, 2025 06:43
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 23, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
99da21b 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Support disable passkey auth (go-gitea#33348)
  Update JS dependencies (go-gitea#33359)
  Enable Typescript `noImplicitAny` (go-gitea#33322)
  Remove duplicate "ResponseWriter.Status" method (go-gitea#33346)
  Fix code button alignment (go-gitea#33345)
  [skip ci] Updated translations via Crowdin
  Support performance trace (go-gitea#32973)
  Make issue suggestion work for all editors (go-gitea#33340)
  Fix issue count (go-gitea#33338)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @techknowlogick @GiteaBot