Fix issue count #33338
Merged
Fix issue count #33338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
wxiaoguang
added
backport/v1.23
lunny
approved these changes
Jan 21, 2025
GiteaBot
added
lgtm/need 1
Zettat123
approved these changes
Jan 21, 2025
GiteaBot
added
lgtm/done
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Jan 21, 2025
wxiaoguang
added a commit
that referenced
this pull request
Jan 21, 2025
Backport #33338 by wxiaoguang Fix #33336 Co-authored-by: wxiaoguang <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jan 23, 2025
* giteaofficial/main: [skip ci] Updated translations via Crowdin Support disable passkey auth (go-gitea#33348) Update JS dependencies (go-gitea#33359) Enable Typescript `noImplicitAny` (go-gitea#33322) Remove duplicate "ResponseWriter.Status" method (go-gitea#33346) Fix code button alignment (go-gitea#33345) [skip ci] Updated translations via Crowdin Support performance trace (go-gitea#32973) Make issue suggestion work for all editors (go-gitea#33340) Fix issue count (go-gitea#33338)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #33336
The old logic is not quite right.
To correctly count the issues, it needs to reset different fields for different cases.
(This PR is still not perfect, it is only a quick fix, there could still be edge cases)