Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Typescript noImplicitAny #33322

Merged
merged 16 commits into from
Jan 22, 2025
Merged

Enable Typescript noImplicitAny #33322

merged 16 commits into from
Jan 22, 2025

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Jan 18, 2025 •
edited
Loading

Enable noImplicitAny and fix all issues. Did not extensively test the UI as the changes are too extensive, but I trust the type checker and linter that no new problems were introduced.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 18, 2025
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 18, 2025
@silverwind silverwind added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 18, 2025
@silverwind silverwind changed the title Enable typescript noImplicitAny Enable Typescript noImplicitAny Jan 19, 2025
silverwind
silverwind commented Jan 19, 2025
View reviewed changes
web_src/js/utils/dom.ts Outdated Show resolved Hide resolved
@GiteaBot GiteaBot removed the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 21, 2025
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 21, 2025
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Jan 21, 2025 •
edited
Loading

" Make issue suggestion work for all editors #33340 " might cause conflicts. #33340 needs to be backported so I think we could merge that first.

Update: manually resolved the conflicts. Only caused by one line in initTextareaMarkdown 30d4a9eee6aece071341a8240aa35ea55cb18f6d

@silverwind silverwind requested a review from lunny January 21, 2025 14:02
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 22, 2025
@wxiaoguang wxiaoguang merged commit c7f4ca2 into go-gitea:main Jan 22, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Jan 22, 2025
@wxiaoguang wxiaoguang deleted the noImplicitAny branch January 22, 2025 07:11
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 23, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
99da21b 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Support disable passkey auth (go-gitea#33348)
  Update JS dependencies (go-gitea#33359)
  Enable Typescript `noImplicitAny` (go-gitea#33322)
  Remove duplicate "ResponseWriter.Status" method (go-gitea#33346)
  Fix code button alignment (go-gitea#33345)
  [skip ci] Updated translations via Crowdin
  Support performance trace (go-gitea#32973)
  Make issue suggestion work for all editors (go-gitea#33340)
  Fix issue count (go-gitea#33338)
@lunny lunny mentioned this pull request Jan 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@silverwind @wxiaoguang @lunny @GiteaBot