Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix closed dependency title #33285

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Fix closed dependency title #33285

merged 2 commits into from
Jan 15, 2025

Conversation

wxiaoguang
Copy link
Contributor

Fix #33283

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 15, 2025
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 15, 2025
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Jan 15, 2025
@wxiaoguang wxiaoguang mentioned this pull request Jan 15, 2025
Closed
@wxiaoguang wxiaoguang added backport/v1.23 This PR should be backported to Gitea 1.23 type/bug labels Jan 15, 2025
@wxiaoguang
Copy link
Contributor Author

image

@silverwind
Copy link
Member

silverwind commented Jan 15, 2025 •
edited
Loading

How about using tw-line-through and remove the CSS rule?

@wxiaoguang
Copy link
Contributor Author

How about using tw-line-through and remove the CSS rule?

I think it's fine to keep current approach in case we'd like to add more styles to it, these elements should share the same style

@wxiaoguang
Copy link
Contributor Author

And there is another reason why I didn't use inline style: it requires more changes like moving {{if .Issue.IsClosed}} is-closed{{end}}. So I prefer to use the existing approach to make it easier to backport and avoid new regressions

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 15, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 15, 2025
@wxiaoguang wxiaoguang merged commit 6659a38 into go-gitea:main Jan 15, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Jan 15, 2025
@wxiaoguang wxiaoguang deleted the fix-dep-title branch January 15, 2025 15:38
wxiaoguang added a commit to wxiaoguang/gitea that referenced this pull request Jan 15, 2025
@wxiaoguang
Fix closed dependency title (go-gitea#33285)
3f026f8 
Fix go-gitea#33283
@wxiaoguang wxiaoguang mentioned this pull request Jan 15, 2025
Merged
@wxiaoguang wxiaoguang added backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! labels Jan 15, 2025
wxiaoguang added a commit that referenced this pull request Jan 15, 2025
@wxiaoguang
Fix closed dependency title (#33285) (#33287)
c09e43a 
Backport #33285
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 16, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
00d24a3 
* giteaofficial/main:
  Only allow admins to rename default/protected branches (go-gitea#33276)
  Enable Typescript `noImplicitThis` (go-gitea#33250)
  Prepare for support performance trace (go-gitea#33286)
  Fix closed dependency title (go-gitea#33285)
  Move some Actions related functions from `routers` to `services` (go-gitea#33280)
  Fix incorrect TagName/BranchName usages (go-gitea#33279)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.23 This PR should be backported to Gitea 1.23 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

PR dependencies are no longer crossed out when they are resolved
4 participants
@wxiaoguang @silverwind @lunny @GiteaBot