Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move some Actions related functions from routers to services #33280

Merged
merged 11 commits into from
Jan 15, 2025
Merged

Move some Actions related functions from routers to services #33280

merged 11 commits into from
Jan 15, 2025

Conversation

Zettat123
Copy link
Contributor

Move the main logic of generateTaskContext and findTaskNeeds to the services layer.

This is a part of #32751, since we need the git context and needs to parse the concurrency expressions.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 15, 2025
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 15, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Jan 15, 2025
@Zettat123 Zettat123 mentioned this pull request Jan 15, 2025
Draft
lunny
lunny reviewed Jan 15, 2025
View reviewed changes
services/actions/utils.go Outdated Show resolved Hide resolved
lunny
lunny reviewed Jan 15, 2025
View reviewed changes
services/actions/utils.go Outdated Show resolved Hide resolved
lunny
lunny reviewed Jan 15, 2025
View reviewed changes
services/actions/utils.go Outdated Show resolved Hide resolved
@lunny
Copy link
Member

lunny commented Jan 15, 2025

Can we have a test for GenerateGiteaContext

@Zettat123
Copy link
Contributor Author

Can we have a test for GenerateGiteaContext

Add a test in fdae294

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 15, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 15, 2025
@wxiaoguang wxiaoguang merged commit d0962ce into go-gitea:main Jan 15, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Jan 15, 2025
@wxiaoguang wxiaoguang deleted the improve-actions-gitcontext branch January 15, 2025 13:35
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 16, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
00d24a3 
* giteaofficial/main:
  Only allow admins to rename default/protected branches (go-gitea#33276)
  Enable Typescript `noImplicitThis` (go-gitea#33250)
  Prepare for support performance trace (go-gitea#33286)
  Fix closed dependency title (go-gitea#33285)
  Move some Actions related functions from `routers` to `services` (go-gitea#33280)
  Fix incorrect TagName/BranchName usages (go-gitea#33279)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Zettat123 @lunny @wxiaoguang @GiteaBot