Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect TagName/BranchName usages #33279

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Fix incorrect TagName/BranchName usages #33279

merged 2 commits into from
Jan 15, 2025

Conversation

wxiaoguang
Copy link
Contributor

Add add a new test

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 15, 2025
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 15, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Jan 15, 2025
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 15, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 15, 2025
@wxiaoguang wxiaoguang changed the title Fix incorrect TagName usages Fix incorrect TagName/BranchName usages Jan 15, 2025
@wxiaoguang wxiaoguang requested a review from Zettat123 January 15, 2025 08:21
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 15, 2025
@wxiaoguang wxiaoguang merged commit f6dbf0e into go-gitea:main Jan 15, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Jan 15, 2025
@wxiaoguang wxiaoguang deleted the fix-tag-name branch January 15, 2025 09:35
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 16, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
00d24a3 
* giteaofficial/main:
  Only allow admins to rename default/protected branches (go-gitea#33276)
  Enable Typescript `noImplicitThis` (go-gitea#33250)
  Prepare for support performance trace (go-gitea#33286)
  Fix closed dependency title (go-gitea#33285)
  Move some Actions related functions from `routers` to `services` (go-gitea#33280)
  Fix incorrect TagName/BranchName usages (go-gitea#33279)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zettat123 Zettat123 Zettat123 approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @Zettat123 @GiteaBot