Add golang back to nix dev environment and pin v1.23 #33275
Conversation
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
6543
changed the title
|
If it is a "regression", what's the regression problem? For example: is there something broken? Sorry I do not use gitpod so I have no idea, but I still have the question: what's the best practice? Keeping adding and removing the version doesn't seem to be the answer .... |
|
there was a tooling issue and from the loogs it was the problem that there was an old version pned (v1.22) so this pull not only adds it back but also pin the new version v1.23 witch should have been bumped with the bump at: Line 3 in fcd0962 so this should be the right fix but i can not verify it ... but not having this pin will make gitea non compilable on some of my systems ... and i guess a lot other nixos users ... |
|
@wxiaoguang beside I can not find any documentation that gitpod implizite uses nix flakes ... so as long as we dont expizite state that in our gitpod config (witch we dont), flake.nix changes should never have any effect in the first place |
|
@6543 gitpod detects usage of flakes and loads them. The gitpod issue is that while it installs the nix version, the env vars point at a pre-installed goroot, thus the toolchain is attempting to use a different version. I tested a fix for this and will send it to this PR |
GiteaBot
added
lgtm/need 1
that is a new feature ... thanks i can not test gitpod because it is now a payed service?!? |
I still have a "classic" account that supposedly will be removed in April. It's still good to have those env vars set anyway in case other services have multiple versions of go installed. |
techknowlogick
added
topic/build
* giteaofficial/main: [skip ci] Updated licenses and gitignores Fix typo in documentation of GetBranchNames() (go-gitea#33330) Fix Account linking page (go-gitea#33325) Fix parentCommit invalid memory address or nil pointer dereference. (go-gitea#33204) Make tracked time representation display as hours (go-gitea#33315) [skip ci] Updated translations via Crowdin [skip ci] Updated translations via Crowdin Fix push message behavior (go-gitea#33215) Add golang back to nix dev environment and pin v1.23 (go-gitea#33275) Trivial fixes (go-gitea#33304)
Fix regression of #32559
@kerwin612 I dont have access to gitpod so please test yourselfe it it works ...
In any case I would suggest to prefere the system that is open to work rather than some closed dev environmend nobody can access ... but thats just my personal thought. PS: I tryed to get gitpod access.... to verify it.