Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a confirm dialog for "sync fork" #33270

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jan 14, 2025

Try to quickly fix #33264

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 14, 2025
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 14, 2025
@github-actions github-actions bot added modifies/translation modifies/templates This PR modifies the template files labels Jan 14, 2025
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Jan 14, 2025

image

@wxiaoguang wxiaoguang added the backport/v1.23 This PR should be backported to Gitea 1.23 label Jan 14, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Jan 14, 2025
@wxiaoguang wxiaoguang added the type/enhancement An improvement of existing functionality label Jan 14, 2025
Copy link
Contributor

@yp05327 yp05327 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe base repo's default branch name can also be displayed.

base repository's default branch

base repository's default branch %s

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 14, 2025
@wxiaoguang
Copy link
Contributor Author

Maybe base repo's default branch name can also be displayed.

It needs extra effort to show the base repo's default branch. I guess current sentence should also be clear enough (everyone knows "default branch") 😆 So I'd like to keep it simple at the moment.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 14, 2025
@techknowlogick techknowlogick enabled auto-merge (squash) January 14, 2025 18:02
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 14, 2025
@techknowlogick techknowlogick merged commit 1299fdb into go-gitea:main Jan 14, 2025
26 checks passed
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jan 14, 2025
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Jan 14, 2025
lafriks pushed a commit that referenced this pull request Jan 14, 2025
@wxiaoguang wxiaoguang deleted the fix-sync-confirm branch January 15, 2025 00:05
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 15, 2025
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Fix some broken route handlers (go-gitea#33268)
  Add a confirm dialog for "sync fork" (go-gitea#33270)
  Fix sidebar milestone link (go-gitea#33269)
  Refactor ref type (go-gitea#33242)
  Fix 500 error when error occurred in migration page (go-gitea#33256)
  Fix missing license when sync mirror (go-gitea#33255)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/done All backports for this PR have been created backport/v1.23 This PR should be backported to Gitea 1.23 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files modifies/translation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give an option to disable Sync Fork
5 participants