Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some broken route handlers #33268

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Fix some broken route handlers #33268

merged 3 commits into from
Jan 14, 2025

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jan 14, 2025 •
edited
Loading

Some mistakes introduced by recent refactoring PRs (some sidebar dropdowns doesn't work)

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 14, 2025
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 14, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jan 14, 2025
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 14, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Jan 14, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 14, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 14, 2025
@techknowlogick techknowlogick enabled auto-merge (squash) January 14, 2025 18:03
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 14, 2025
@techknowlogick techknowlogick merged commit 4d399e7 into go-gitea:main Jan 14, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 14, 2025
@wxiaoguang wxiaoguang deleted the fix-issue-route branch January 15, 2025 00:04
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 15, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
ceae9c4 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Fix some broken route handlers (go-gitea#33268)
  Add a confirm dialog for "sync fork" (go-gitea#33270)
  Fix sidebar milestone link (go-gitea#33269)
  Refactor ref type (go-gitea#33242)
  Fix 500 error when error occurred in migration page (go-gitea#33256)
  Fix missing license when sync mirror (go-gitea#33255)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiifong hiifong hiifong approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
5 participants
@wxiaoguang @lunny @hiifong @techknowlogick @GiteaBot