Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify context ref name #33267

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Simplify context ref name #33267

merged 2 commits into from
Jan 15, 2025

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jan 14, 2025 •
edited
Loading

By using the new design, the code could be simplified and clearer than before.

  • IsViewBranch: replaced by RefFullName.IsBranch
  • IsViewTag: replaced by RefFullName.IsTag

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 14, 2025
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 14, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Jan 14, 2025
@wxiaoguang wxiaoguang mentioned this pull request Jan 14, 2025
Merged
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 15, 2025
@lunny lunny added this to the 1.24.0 milestone Jan 15, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 15, 2025
@wxiaoguang wxiaoguang merged commit fcd0962 into go-gitea:main Jan 15, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the refactor-branch-dropdown branch January 15, 2025 03:15
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 15, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
cc0a520 
* giteaofficial/main:
  Simplify context ref name (go-gitea#33267)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zettat123 Zettat123 Zettat123 approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @Zettat123 @GiteaBot