Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 500 error when error occurred in migration page #33256

Merged
merged 6 commits into from
Jan 14, 2025
Merged

Fix 500 error when error occurred in migration page #33256

merged 6 commits into from
Jan 14, 2025

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Jan 14, 2025 •
edited
Loading

Before:
image

After:
image

Reason:
the template should be repo/migrate/{service type}
But input element service is not in the form.

Related: #33081

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 14, 2025
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 14, 2025
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Jan 14, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 14, 2025
@lunny lunny added type/bug backport/v1.23 This PR should be backported to Gitea 1.23 labels Jan 14, 2025
@yp05327
Copy link
Contributor Author

yp05327 commented Jan 14, 2025 •
edited
Loading

@lunny
No need to backport. Caused by https://github.com/go-gitea/gitea/pull/33081/files#diff-5d520c9ff3129f2bd85d6c124dcd362a027c8e7d4860ec48220b55b65da273bd

@yp05327
Copy link
Contributor Author

yp05327 commented Jan 14, 2025

I think we can add a test for this.

@lunny lunny removed the backport/v1.23 This PR should be backported to Gitea 1.23 label Jan 14, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jan 14, 2025
wxiaoguang
wxiaoguang approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, my bad, thank you for fixing it

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 14, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) January 14, 2025 06:07
@wxiaoguang wxiaoguang merged commit 3a749fc into go-gitea:main Jan 14, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Jan 14, 2025
@wxiaoguang wxiaoguang mentioned this pull request Jan 14, 2025
Closed
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 15, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
ceae9c4 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Fix some broken route handlers (go-gitea#33268)
  Add a confirm dialog for "sync fork" (go-gitea#33270)
  Fix sidebar milestone link (go-gitea#33269)
  Refactor ref type (go-gitea#33242)
  Fix 500 error when error occurred in migration page (go-gitea#33256)
  Fix missing license when sync mirror (go-gitea#33255)
@yp05327 yp05327 deleted the fix-500err-migrate branch January 17, 2025 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@yp05327 @lunny @wxiaoguang @GiteaBot