Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JS and PY dependencies #33249

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Update JS and PY dependencies #33249

merged 4 commits into from
Jan 16, 2025

Conversation

silverwind
Copy link
Member

  • Update all JS and PY dependencies
  • Tested affected dependencies
  • Disabled async-preventdefault lint rule because it brought up new false-positives.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 13, 2025
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 13, 2025
@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 13, 2025
package.json Outdated Show resolved Hide resolved
@wxiaoguang
Copy link
Contributor

Many new warnings:

npm warn ERESOLVE overriding peer dependency
npm warn While resolving: @eslint/[email protected]
npm warn Found: [email protected]
npm warn node_modules/eslint
npm warn   dev eslint@"8.57.0" from the root project
npm warn   33 more (@babel/eslint-parser, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peerOptional eslint@"^9.10.0" from @eslint/[email protected]
npm warn node_modules/eslint-plugin-github/node_modules/@eslint/compat
npm warn   @eslint/compat@"^1.2.3" from [email protected]
npm warn   node_modules/eslint-plugin-github
npm warn
npm warn Conflicting peer dependency: [email protected]
npm warn node_modules/eslint
npm warn   peerOptional eslint@"^9.10.0" from @eslint/[email protected]
npm warn   node_modules/eslint-plugin-github/node_modules/@eslint/compat
npm warn     @eslint/compat@"^1.2.3" from [email protected]
npm warn     node_modules/eslint-plugin-github

up to date in 582ms

@silverwind
Copy link
Member Author

Many new warnings:

npm warn ERESOLVE overriding peer dependency
npm warn While resolving: @eslint/[email protected]
npm warn Found: [email protected]
npm warn node_modules/eslint
npm warn   dev eslint@"8.57.0" from the root project
npm warn   33 more (@babel/eslint-parser, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peerOptional eslint@"^9.10.0" from @eslint/[email protected]
npm warn node_modules/eslint-plugin-github/node_modules/@eslint/compat
npm warn   @eslint/compat@"^1.2.3" from [email protected]
npm warn   node_modules/eslint-plugin-github
npm warn
npm warn Conflicting peer dependency: [email protected]
npm warn node_modules/eslint
npm warn   peerOptional eslint@"^9.10.0" from @eslint/[email protected]
npm warn   node_modules/eslint-plugin-github/node_modules/@eslint/compat
npm warn     @eslint/compat@"^1.2.3" from [email protected]
npm warn     node_modules/eslint-plugin-github

up to date in 582ms

Ah yes, that is github/eslint-plugin-github#585. We need to downgrade and pin eslint-plugin-github, likely until we upgrade to eslint 9.

@silverwind
Copy link
Member Author

We need to downgrade and pin eslint-plugin-github, likely until we upgrade to eslint 9.

Done in 50c7bc1.

@silverwind
Copy link
Member Author

I will leave async-preventdefault disabled because even thought it currently raises no error, it's bound to deliver mostly false-positives until github/eslint-plugin-github#599 is fixed. The rule itself got more precises in github/eslint-plugin-github#567, that's the reason we saw new errors in 5.1.5.

@silverwind
Copy link
Member Author

@wxiaoguang looking good now that I've downgraded and pinned that plugin?

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 15, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 15, 2025
@wxiaoguang
Copy link
Contributor

@wxiaoguang looking good now that I've downgraded and pinned that plugin?

I haven't tested (it's difficult to pick your branch from my git tool since there are too many outdated branches), if there is nothing wrong on you side, then I have no problem.

@silverwind
Copy link
Member Author

it's difficult to pick your branch from my git tool

Use git cli: git checkout -t silverwind/branch 😉

@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 16, 2025
@silverwind silverwind enabled auto-merge (squash) January 16, 2025 09:51
@silverwind silverwind merged commit ab347fd into go-gitea:main Jan 16, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Jan 16, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 16, 2025
@silverwind silverwind deleted the deps-86 branch January 16, 2025 09:58
@wxiaoguang
Copy link
Contributor

Actually I need to work with different forks simultaneously and switch between branches frequently.

It's really difficult to distinguish the branches without a clear name .... even with git cli, I can't remember so many branch names I am working on.

image

image

image

@silverwind
Copy link
Member Author

Yeah, it's not ideal that you don't see the associated tracking remote for each branch, that would help.

zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 17, 2025
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Fix incorrect ref usages (go-gitea#33301)
  Update JS and PY dependencies (go-gitea#33249)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependencies modifies/frontend size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants