Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run github workflows on ubuntu-24.04 #33247

Closed
wants to merge 1 commit into from

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Jan 13, 2025

Specify exact Ubuntu version which will be better in the long run as it prevents unwanted surprises when the ubuntu-latest label is being upgraded by GitHub. Currently it is still pointing to 22.04. Also this eliminated this warning annotation seen on current workflows:

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see actions/runner-images#10636

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 13, 2025
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 13, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 13, 2025
@lunny lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Jan 13, 2025
@wxiaoguang
Copy link
Contributor

TBH, I am not a fan or hard-coding the version if the "latest" works well. And I think we do not need to do anything since "ubuntu-latest pipelines will use ubuntu-24.04 soon."

@silverwind
Copy link
Member Author

silverwind commented Jan 13, 2025

Could keep it at latest as well if you prefer. Slightly less maintenance and the app is very os-independant anyways. I only did this to eliminate the "warning" that github shows on the actions page which isn't even a warning in the common sense, more like informational.

@silverwind
Copy link
Member Author

Let's keep latest to reduce maintenance burden.

@silverwind silverwind closed this Jan 13, 2025
@silverwind silverwind deleted the ubuntu24 branch January 13, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/internal size/M Denotes a PR that changes 30-99 lines, ignoring generated files. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants