Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assignee list overlapping in Issue sidebar #33176

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Fix assignee list overlapping in Issue sidebar #33176

merged 1 commit into from
Jan 9, 2025

Conversation

wxiaoguang
Copy link
Contributor

Fix #33170

image

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 9, 2025
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 9, 2025
@wxiaoguang wxiaoguang mentioned this pull request Jan 9, 2025
Closed
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Jan 9, 2025
@wxiaoguang wxiaoguang added the backport/v1.23 This PR should be backported to Gitea 1.23 label Jan 9, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 9, 2025
@yp05327
Copy link
Contributor

yp05327 commented Jan 9, 2025

Not releated to this issue, but it seems that the other places are broken? Or it is expected?
image
image

@wxiaoguang
Copy link
Contributor Author

Not worse than 1.22 (actually the sidebar has many edge cases ......)

image

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 9, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 9, 2025
@lunny lunny merged commit a5043af into go-gitea:main Jan 9, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Jan 9, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 9, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jan 9, 2025
@wxiaoguang @GiteaBot
Fix assignee list overlapping in Issue sidebar (go-gitea#33176)
ebfc24d 
Fix  go-gitea#33170

![image](https://github.com/user-attachments/assets/714cebdc-ee76-43e3-9ece-a189f8ecb17a)

![image](https://github.com/user-attachments/assets/cbb58425-42b4-41ee-ba3c-7efbd24607dc)
@GiteaBot GiteaBot mentioned this pull request Jan 9, 2025
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Jan 9, 2025
@wxiaoguang wxiaoguang deleted the fix-sidebar-assignee branch January 9, 2025 18:23
wxiaoguang added a commit that referenced this pull request Jan 9, 2025
@GiteaBot @wxiaoguang
Fix assignee list overlapping in Issue sidebar (#33176) (#33181)
6f6c66a 
Backport #33176 by wxiaoguang

Fix  #33170

Co-authored-by: wxiaoguang <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 10, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
9e7866c 
* giteaofficial/main:
  Fix raw file API ref handling (go-gitea#33172)
  [skip ci] Updated translations via Crowdin
  Fix ACME panic (go-gitea#33178)
  Automerge supports deleting branch automatically after merging (go-gitea#32343)
  Fix branch dropdown not display ref name (go-gitea#33159)
  Add .run to gitignore (go-gitea#33175)
  Fix assignee list overlapping in Issue sidebar (go-gitea#33176)
  Fix pam auth test regression (go-gitea#33169)
  Move repo size to sidebar (go-gitea#33155)
  Fix fuzz test (go-gitea#33156)
  Refactor older tests to use testify (go-gitea#33140)
  [skip ci] Updated translations via Crowdin
  Fix typo in gitea downloader test and add missing codebase in `ToGitServiceType` (go-gitea#33146)
  Fix form width (go-gitea#33151)
  Convert github.com/xanzy/go-gitlab into gitlab.com/gitlab-org/api/client-go (go-gitea#33126)
  Refactor HTMLFormat, update chroma render, fix js error (go-gitea#33136)
  Add missed transaction on setmerged (go-gitea#33079)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yp05327 yp05327 yp05327 approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.23 This PR should be backported to Gitea 1.23 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Assignee list overlapping in Issue sidebar
4 participants
@wxiaoguang @yp05327 @lunny @GiteaBot