Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "stop time tracking button" on navbar #33084

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Fix "stop time tracking button" on navbar #33084

merged 2 commits into from
Jan 2, 2025
+4 −4

Conversation

wxiaoguang
Copy link
Contributor

Fix #33083

By the way (something I was working on):

  1. relax color/background-color for more markup elements
  2. fix a command line sentence error

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 2, 2025
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 2, 2025
@wxiaoguang wxiaoguang added backport/v1.23 This PR should be backported to Gitea 1.23 and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 2, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/templates This PR modifies the template files labels Jan 2, 2025
@wxiaoguang wxiaoguang changed the title fix Fix "stop time tracking button" on navbar Jan 2, 2025
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 2, 2025
@wxiaoguang wxiaoguang mentioned this pull request Jan 2, 2025
Closed
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 2, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 2, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 2, 2025
@lunny lunny merged commit 9ac536a into go-gitea:main Jan 2, 2025
26 checks passed
lunny pushed a commit that referenced this pull request Jan 2, 2025
@wxiaoguang
Fix "stop time tracking button" on navbar (#33084)
9ac536a 
Fix #33083

By the way (something I was working on):

1. relax color/background-color for more markup elements
2. fix a command line sentence error
@GiteaBot GiteaBot added this to the 1.24.0 milestone Jan 2, 2025
@GiteaBot
Copy link
Collaborator

GiteaBot commented Jan 2, 2025

I was unable to create a backport for 1.23. @wxiaoguang, please send one manually. 🍵

go run ./contrib/backport 33084
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Jan 2, 2025
@wxiaoguang wxiaoguang deleted the fix-stop-watch branch January 3, 2025 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delvh delvh delvh approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/manual No power to the bots! Create your backport yourself! backport/v1.23 This PR should be backported to Gitea 1.23 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Stop time tracking button fails to redirect to the issue page
4 participants
@wxiaoguang @GiteaBot @lunny @delvh