Make Gitea always use its internal config, ignore /etc/gitconfig
#33076
+13
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
wxiaoguang
changed the title
/etc/git/config/etc/gitconfig
wxiaoguang
commented
Jan 2, 2025
wxiaoguang
added
the
pr/breaking
wxiaoguang
force-pushed
the
fix-git-global-config
branch
from
afa949f to
0201e02
Compare
lunny
approved these changes
Jan 2, 2025
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Jan 2, 2025
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
lunny
pushed a commit
that referenced
this pull request
Jan 2, 2025
…33076) In history, Gitea could use the system config `/etc/gitconfig` because some users said that "they might put certNonceSeed in it" Actually, we shouldn't not use it, because it also causes conflicts (there are already some fixes like #28848) To make the system clear, I think it's worth to introduce the breaking change: add `GIT_CONFIG_NOSYSTEM=1` to all git commands. ##⚠️ BREAKING⚠️ For most users, nothing need to do. If you have made changes to `/etc/gitconfig` to affect Gitea's behavior, you need to move these config options to Gitea's internal git config file, it is usually in Gitea's `{AppDataPath}/home/.git` directory.
GiteaBot
removed
the
reviewed/wait-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In history, Gitea could use the system config
/etc/gitconfigbecause some users said that "they might put certNonceSeed in it"Actually, we shouldn't not use it, because it also causes conflicts (there are already some fixes like #28848)
To make the system clear, I think it's worth to introduce the breaking change: add
GIT_CONFIG_NOSYSTEM=1to all git commands.For most users, nothing need to do.
If you have made changes to
/etc/gitconfigto affect Gitea's behavior, you need to move these config options to Gitea's internal git config file, it is usually in Gitea's{AppDataPath}/home/.gitdirectory.