Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unittest and repo create bug #33061

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Fix unittest and repo create bug #33061

merged 1 commit into from
Dec 31, 2024

Conversation

wxiaoguang
Copy link
Contributor

  1. StatDir was not right, fix the FIXME
  2. Clarify the test cases for IsUsableRepoName
  3. Fix regression bug in repo-new.ts

Fix #33060

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 31, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 31, 2024
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/frontend labels Dec 31, 2024
@wxiaoguang wxiaoguang mentioned this pull request Dec 31, 2024
Closed
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Dec 31, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 31, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 31, 2024
@wxiaoguang wxiaoguang merged commit a0853e2 into go-gitea:main Dec 31, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Dec 31, 2024
@wxiaoguang wxiaoguang deleted the refactor-name-check branch December 31, 2024 10:45
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 2, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
9754baf 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  unset XDG_HOME_CONFIG as gitea manages configuration locations (go-gitea#33067)
  Refactor repo-new.ts (go-gitea#33070)
  Refactor pull-request compare&create page (go-gitea#33071)
  feat: link to nuget dependencies (go-gitea#26554)
  Remove some unnecessary template helpers (go-gitea#33069)
  Inherit submodules from template repository content (go-gitea#16237)
  [skip ci] Updated translations via Crowdin
  feat(action): issue change title notifications (go-gitea#33050)
  Use project's redirect url instead of composing url (go-gitea#33058)
  Fix unittest and repo create bug (go-gitea#33061)
  Fix locale type (go-gitea#33059)
  Refactor maven package registry (go-gitea#33049)
  Optimize the installation page (go-gitea#32994)
  [Feature] Private README.md for organization (go-gitea#32872)
  Make issue suggestion work for new PR page (go-gitea#33035)
  Add IntelliJ Gateway's .uuid to gitignore (go-gitea#33052)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delvh delvh delvh approved these changes

@Zettat123 Zettat123 Zettat123 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Cannot select "Initialize Repository" when creating a repo
4 participants
@wxiaoguang @Zettat123 @delvh @GiteaBot