Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move team related functions to service layer #32537

Merged
merged 10 commits into from
Nov 27, 2024
Merged

Move team related functions to service layer #32537

merged 10 commits into from
Nov 27, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 16, 2024 •
edited
Loading

There are still some functions under models after last big refactor about models. This change will move all team related functions to service layer with no code change.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 16, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 16, 2024
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 16, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Nov 16, 2024
@pull-request-size pull-request-size bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 16, 2024
@lunny lunny mentioned this pull request Nov 21, 2024
Draft
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 27, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 27, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 27, 2024
@lunny lunny enabled auto-merge (squash) November 27, 2024 20:48
@lunny lunny merged commit f62f68c into go-gitea:main Nov 27, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Nov 27, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 27, 2024
@lunny lunny deleted the lunny/move_team_service branch November 27, 2024 22:38
@wxiaoguang wxiaoguang modified the milestones: 1.24.0, 1.23.0 Nov 28, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 28, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
d522007 
* giteaofficial/main:
  Allow cropping an avatar before setting it (go-gitea#32565)
  Add webpack EnvironmentPlugin (go-gitea#32661)
  Move team related functions to service layer (go-gitea#32537)
  Make frontend unit test code could know it is in testing (go-gitea#32656)
  Add priority to protected branch (go-gitea#32286)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yp05327 yp05327 yp05327 left review comments

@delvh delvh delvh approved these changes

@wolfogre wolfogre wolfogre approved these changes

@wxiaoguang wxiaoguang Awaiting requested review from wxiaoguang

@Zettat123 Zettat123 Awaiting requested review from Zettat123

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @wolfogre @yp05327 @delvh @wxiaoguang @GiteaBot