Make ContextPopup stateless, improve fetching logic

[silverwind]

1. ContextPopup is now a stateless component, accepting only props to render the popup
2. Loading state is gone, the requests are fast enough to not need a loading state
3. Error state is gone, we don't need to show any errors on this, imho
4. Popups now have the tooltip role which enables singleton behaviour, so multiple such popups won't show at the same time (happens when links are close together)
5. Increased the interactiveBorder to 15px
6. Tooltip init is now lazy
7. Repo link in tooltip is now clickable

Fixes: #31161
Helps with: #30275

Popup over existing issue:

Nonexisting issue does not show anything:

I think this is a nice bugfix for 1.22.

[silverwind]

In 434287a I added another data attribute to track the loading state, ensuring this will never issue two GET requests at the same time for the same link, no matter which DOM events trigger on the link.

[wxiaoguang]

Sorry but I do not think the change is good enough.

When you'd like to reuse an existing instance, all states should be handled carefully. For example

• Hover on #1, then #1 is loading, then hover to #2, should #2 be loading immediately? (I do not see so in this PR)
• Hover on #1, then #1 fails due to temp network error. Then re-hover on #1, will it reload?
• Hover on #1, then #1 loads, then #1 changes, then re-hover on #1, will it reload?

I do not think it's worth to force it only use one instance.

I strongly prefer the old approach, which is simple enough and doesn't really cause any problem.

[silverwind]

I think single instance is preferable because with the increased interactivity border, it's possible to have situations like this:

As for the other questions, I will check. Of course the last hovered instance should always win.

[wxiaoguang]

I think single instance is preferable because with the increased interactivity border, it's possible to have situations like this:

I wouldn't say it is a serious problem, and it could be fixed by add some "hiding" code.

[silverwind]

The problem with double tooltip can also be seen with the commit status in commit list. I think it could be fixed by adding a singleton="tooltip" during creation, so that only one instance per singleton can show. Currently this mechanism is active when role is tooltip but I think it may need to become more flexible.