Fix

go-gitea · Jan 11, 2025 · 1660737 · 1660737
1 parent 35a2b9b
commit 1660737
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/modules/git/ref.go b/modules/git/ref.go
@@ -105,7 +105,7 @@ func (ref RefName) IsFor() bool {
 	return strings.HasPrefix(string(ref), ForPrefix)
 }
 
-var forReviewPattern = regexp.MustCompile(ForReviewPrefix + `^[1-9][0-9]\d*$`)
+var forReviewPattern = regexp.MustCompile(ForReviewPrefix + `[1-9]\d*$`)
 
 func (ref RefName) IsForReview() bool {
 	return forReviewPattern.MatchString(string(ref))

diff --git a/modules/git/ref_test.go b/modules/git/ref_test.go
@@ -26,6 +26,17 @@ func TestRefName(t *testing.T) {
 	assert.Equal(t, "main", RefName("refs/for/main").ForBranchName())
 	assert.Equal(t, "my/branch", RefName("refs/for/my/branch").ForBranchName())
 
+	// Test for review name
+	assert.Equal(t, false, RefName("refs/for-review/-1").IsForReview())
+	assert.Equal(t, false, RefName("refs/for-review/0").IsForReview())
+	assert.Equal(t, false, RefName("refs/for-review/01").IsForReview())
+	assert.Equal(t, true, RefName("refs/for-review/1").IsForReview())
+	assert.Equal(t, true, RefName("refs/for-review/10").IsForReview())
+	assert.Equal(t, true, RefName("refs/for-review/10999").IsForReview())
+	assert.Equal(t, false, RefName("refs/for-review/a10").IsForReview())
+	assert.Equal(t, false, RefName("refs/for-review/10a").IsForReview())
+	assert.Equal(t, false, RefName("refs/for-review/abc").IsForReview())
+
 	// Test commit hashes.
 	assert.Equal(t, "c0ffee", RefName("c0ffee").ShortName())
 }