service: workaround for non-unicode strings in Variables #4082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekparker
reviewed
Aug 21, 2025
| var v2 *variableWithoutMarshaler = (*variableWithoutMarshaler)(v) | ||
| if v2.Kind == reflect.String && !utf8.ValidString(v2.Value) { | ||
| value := v2.Value | ||
| // Should we blot out the value with something obviously wrong? Like: |
Member
There was a problem hiding this comment.
I don't think this is a bad idea.
Member
Author
There was a problem hiding this comment.
The reason I'm esitant about this is that by not doing it we do send a mangled string (if it is not representable in utf8), but only a little bit. So it's more backwards compatible. However it could also be valuable to make the problem more obvious.
You decide.
When string Variables containing non-unicode strings are encoded into json their value is changed, which leads to subtle bugs such as described in issue go-delve#4072. This CL addresses the problem by adding a new field to the api.Variable struct that will be used to transport the variable's value for strings that can not be unicode-encoded. This is the best we can do without breaking backwards compatibility. For our Go code the change is handled transparently by a MarshalJSON/UnmarshalJSON on the api.Variable type. Fixes go-delve#4072
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When string Variables containing non-unicode strings are encoded into
json their value is changed, which leads to subtle bugs such as
described in issue #4072.
This CL addresses the problem by adding a new field to the api.Variable
struct that will be used to transport the variable's value for strings
that can not be unicode-encoded.
This is the best we can do without breaking backwards compatibility.
For our Go code the change is handled transparently by a
MarshalJSON/UnmarshalJSON on the api.Variable type.
Fixes #4072