fix: do not consume request body unless explicitly requested #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new option
LogAdditionalAttrs
and deprecatesLogExtraAttrs
:LogAdditionalAttrsOptions.IncludeRequestBody
to provide control over when request body is consumed and passed toLogAdditionalAttrsOptions.AdditionalAttrs
. The default isfalse
(vs.LogExtraAttrs
which would always consume the entire body) which could lead to high memory usage even when not neededLogDetails
toLogAdditionalAttrsOptions.AdditionalAttrs
which contains the same params asLogExtraAttrs
does but supports extending additional details if/when needed to avoid breaking changes moving forwardThe approach taken is not a breaking change, however if desired, the implementation can be simplified which would result in a breaking change and a major bump.
Resolves #62