Don't return NSXMLDTD objects #547
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GNUstep does not deal correctly with DTD nodes, which causes crashes. Just disable their creation until this is properly dealt with.
rfm
requested changes
Oct 12, 2025
There was a problem hiding this comment.
While I'm not really familiar with NSXMLNode (never having had cause to use it), this change makes no sense to me.
If, as the comment says, DTD nodes cause crashes, then please can we have some indication how/why things crash (testcases would be good) so that there is some chance of the code being fixed.
But also, if the comment is correct then why just remove two lines here and return nil? Presumably it would make more sense to comment out all the code creating DTD nodes, not just this one case.
This reverts commit 709d536.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating this PR for a patch. No need to merge this in.
GNUstep does not deal correctly with DTD nodes, which causes crashes. Just disable their creation until this is properly dealt with.