[wip] change @sym to a classdef #950
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure how to do this properly, but symfun should support casting to sym. Make "formula" use this new casting.
I'm not even sure this cast was correct for old-style class but its certainly not for classdef. Anyway, "formula" is semantically correct in these cases.
Fixes for casting to sym
We commonly ensure inputs are sym. In many cases, this was done using "varargin = sym(varargin)". Use a loop instead so that sym(cell) need not return a cell.
This was still present on the classdef branch but not being used anymore in master.
Need to track these down
Rename to _size and make a special magic accessor for symfun.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up the excellent work of @genuinelucifer and @latot in #590. There is a lot of background and discussion at #590.
I merged master into that work. Many changes were no longer needed which simplified things. I also did not indent the ctor code which means it should be easier to keep this up-to-date with master than it was before.
symandsymfunctor.if (logical(obj))seems broken again: TODO: