add simplify identities #529
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inst/@sym/simplify.m
Outdated
| %% Simplify an expression. | ||
| %% | ||
| %% @var{y} can be 'special' or 'complete'. | ||
| %% 'special' will expand the equation using identities to simplify. |
There was a problem hiding this comment.
i choose 'special' because are special functions, like beta, gamma, etc.
add simplify identities change description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, well this time i propose implement in simplify the expand_func, its very useful specially if we use special functions like beta or gamma, in this case the user can choose how treat the function, in sympy we have 3 options to simplify, "simplify", "combsimp", and "expand_func", actually simplify can cover the combsimp functions, so we only add two.
maybe use directly:
instead of choose the method, what do you think?
the tests will fail until merge this: #526
Cya.