nroer site updates #1956
Open
nroer site updates #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essage for non-login users when user click on comment button
…ken,group_id,is_authenticated.rating issue resolved
… except home workspace
…replaced to group_obj._id argument
katkamrachana
requested changes
Jul 6, 2018
|
|
||
| function check_user_access_policy(obj){ |
There was a problem hiding this comment.
use widget_user_access_modal which does this
| <input type="hidden" name="is_contributor" class="is-contributor-{{node.pk}}" "{% if request.user.id in node.contributors %}" value= "True" "{% endif %}"> | ||
| <input type="hidden" name="is_authenticated" class="is_authenticated" "{% if user.is_authenticated %}" value="True" "{% else %}" value= "False" "{% endif %}"> |
There was a problem hiding this comment.
is_authenticated flag can be checked on templates using block-tags and also in views. why would we need a hidden variable for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.In rating.html file changed,added three hidden input type field for csrf_token,group_id,is_authenticated.
2.In in-line-texteditor.html , added js function to show alert message for non-login users when user click on
commentbutton3.In lms.html ,showing
gallerytext on all workspaces tab excepthomeworkspace.4.In widget_user_search.html, replaced text Find Students to Find Members.
5.In method.py file,
group_objargument of user_access_policy() function replaced togroup_obj._idargument