[bug 827] - toggle-visibility no longer opens a new window if terminator is running #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfickel
changed the title
|
Duplicate of PR: #824 |
|
Your fix will not fix --new-tab |
|
Closing as dupe of #824 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent PR #797 added the toggle-visibility option to circumvent some wayland problems. There was a problem, though: it would also create a new Terminator window on each toggle. Tested on Ubuntu 23.04.
The fix
I simply changed the if/else position. On the original PR,
ipc.new_window_cmdline(optionslist)would always by runningterminator --toggle-visibility, and now a new window will never be created if --toggle-visibility is passed, as I believe would be the expected usage.