Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: user registration #19

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: user registration #19

wants to merge 3 commits into from

Conversation

leohhhn
Copy link
Collaborator

@leohhhn leohhhn commented Apr 8, 2024

Description

With the previous talks about moderation on Memeland, this PR changes Memeland to only allow addresses registered in r/demo/users to post memes. r/demo/users is invite-only.

This feature proves difficult to test programatically, as r/demo/users is invite-only, and I have no access to registered addresses/addresses with invites. With no way to mock addresses, testing this manually is the only way right now afaik. Check out this issue where I detail this problem out.

@leohhhn leohhhn self-assigned this Apr 8, 2024
Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for gno-memeland canceled.

Name Link
🔨 Latest commit 6c72c9f
🔍 Latest deploy log https://app.netlify.com/sites/gno-memeland/deploys/661366d2c24e7f0008a90b04

@zivkovicmilos zivkovicmilos marked this pull request as draft April 8, 2024 08:39
@leohhhn
Copy link
Collaborator Author

leohhhn commented Apr 29, 2024

From a discussion with @jaekwon, we can go this route for now - until we figure out a better way to moderate memeland.

@leohhhn leohhhn marked this pull request as ready for review April 29, 2024 15:38
@leohhhn leohhhn requested a review from zivkovicmilos May 7, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant