Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a Poll package and realm. #3980

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wyhaines
Copy link
Contributor

This is a simple polling package and realm. It allows the creation of multi-option polls with the ability to vote for more than one option.

It was based off of Leon's simple polling realm in the docs, but expanded to handle any number of polls with any number of options.

This branch supercedes kh.add-poll-package-and-realm, and this PR replaces #3776. It was far simpler to just make a completely clean new branch with the code than to try to clean up an old rebase.

… Together, these provide a way to run polls using gno.land.
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Mar 19, 2025
@Gno2D2 Gno2D2 requested a review from a team March 19, 2025 22:53
@Gno2D2 Gno2D2 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Mar 19, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Mar 19, 2025

🛠 PR Checks Summary

🔴 Pending initial approval by a review team member, or review from tech-staff

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
  • The pull request description provides enough details
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🔴 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🔴 Requirement not satisfied
└── 🔴 If
    ├── 🔴 Condition
    │   └── 🔴 Or
    │       ├── 🔴 At least 1 user(s) of the organization reviewed the pull request (with state "APPROVED")
    │       ├── 🔴 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🔴 This pull request is a draft
    └── 🔴 Else
        └── 🔴 And
            ├── 🟢 This label is applied to pull request: review/triage-pending
            └── 🔴 On no pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission
The pull request description provides enough details

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)
    └── 🟢 Not (🔴 Pull request author is user: dependabot[bot])

Can be checked by

  • team core-contributors

@jefft0
Copy link
Contributor

jefft0 commented Mar 20, 2025

Hi @wyhaines . The API allows to edit option text. This means that the poll owner can do:

AddOption("0000001", "yes")
AddOption("0000001", "no")

Then let a bunch of people vote. Then switch the options:

EditOption("0000001", 0, "no")
EditOption("0000001", 1, "yes")

If this was a vote on an important topic, then this could be a security risk. What do you think? Should there be a limit to editing the poll options after voting starts?

@michelleellen michelleellen requested review from jefft0 and leohhhn March 20, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages. review/triage-pending PRs opened by external contributors that are waiting for the 1st review
Projects
Status: No status
Status: Triage
Development

Successfully merging this pull request may close these issues.

3 participants