Content-negotiation using muuntaja #10
Conversation
test/hato/middleware_test.clj
Outdated
| @@ -6,6 +6,17 @@ | |||
| GZIPOutputStream) | |||
| (java.io ByteArrayOutputStream ByteArrayInputStream InputStream))) | |||
|
|
|||
| (defmulti as-string type) | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
way more (transitive) dependencies, including manifold. That's a lot for just some conversions.
.travis.yml
Outdated
|
|
||
| notifications: | ||
| slack: | ||
| secure: avvMZRXVsixGTaSDXYOO06Q4K4e/u0/XQBY7QoRLUtDjesCT9iG9WPqOkEGUAgQ4G/+hNFdIVh4POuL/gVVW/cJ2Nmvmne2kywXck+DJawVlJfIF6Wh+0y961XmlDAOZomN0n8o5MN+2WJvXlfPgcDTcdCeZrtTOTAzdwQd7wDqPV4Vh0GyQYXe2pSVkhahwkVqpQ2pjcMhG5u4r2flW7XzZAr6pQeDJx033tIntUzrwsUOY3gaor8RwMxWzlrQjATPqhuvIHmKMtbi5ByPXfqfXGqR862qhabpiDy6qquZYSckFkeshF2Ht/cS9cwJ2yzu2aKe+s6G1QfFe8rtMjem3YYuIytrwDNDTV6iafvqJhYBcCCitjcfyBy5ZX8cRHhXD5xhZGk4Ex3dZsd7otTaTRET1mdLJ9FFd+OJu5FLcge0kSQlh8tcmLts1kECMIVUL+hojXZRsxQQ0tCsQOaX8lETd0M5TuTg7S3J17u3R8dTwSfNZDoDI7IhRo50OEHlsvB71LjPQFz5vZtEGeD6LuG80MRC3iVRZTqrdlnB1as9WLPVikN2nwEV/8aLHI0ByBgzOUIJ0YXTetdZJbomvr8Jrgl24G4fgBREw/pN0SJ6ddhWouXdSpERA2Wob+4c0Qqqz32gjxQRhkg8OH9x8uCpUyvNgAOA4tJFgTb0= |
There was a problem hiding this comment.
Is this token supposed to be here? I'ts seems to be something sensitive.
There was a problem hiding this comment.
That's how to setup slack notifications, and the token is encrypted: https://docs.travis-ci.com/user/notifications/
There was a problem hiding this comment.
But you might not want to use this because it's not your slack channel :)
CHANGELOG.md
Outdated
| @@ -1,40 +0,0 @@ | |||
| # Change Log | |||
There was a problem hiding this comment.
Is this changelog meant to be removed?
There was a problem hiding this comment.
Yes, as it was of no value (as it's empty). Might be a bit drastical for a PR.
However, you can decide otherwise and keep the changelog.
Use muuntaja to encode request data / decode response data based upon content-type header.
chrisbetz
force-pushed
the
feature/muuntaja
branch
from
c4a2278 to
89d2b2e
Compare
Hi,
I wanted to reuse code (here: muuntaja for content negotation), also I wanted to be able to rely on the content-type header for coercion.
Thus I changed things a bit (ok, more than a bit). Maybe you want to check it out.
If it's more than you're willing to accept: I forked the project to gorillalabs/hato, as I need it for production and must move forward quickly). So, take your time.
Happy hacking
Chris
This change is