Open
Conversation
This commit also adds the changes produced by running make.js.
|
Thank you for making this PR! as somebody who uses a screen reader, having this changed merged in would be super helpful, and give presenters who use screen readers one more reason to adopt remark. |
Collaborator
|
@LangdalP: thank you for contributing! I hadn't seen this, I'm sorry. Would you mind sync'ing your fork and resolving the conflicting file, so we can review your changes? Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was testing how well a screen reader would work with remark.js slides. In general, it works quite well, but the screen reader does not catch that the content of a slide changes when the user clicks the left or right arrows. I have fixed this by adding an ARIA live region. This gives a hint to screen readers that it should listen for changes inside the region, and read these aloud.
I have tested this change with Mac OSX's VoiceOver utility. The change works as intended. However, I am not sure if it is possible to write any sensible automated tests for this, so I have not added any tests.
Note that after modifying
src/remark.htmland running make.js, I observed that two other files had changed. I assume these two files should also be a part of the check-in, since they are not gitignored. Please let me know if that is wrong.