Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gulp for building editableCell #33

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Use gulp for building editableCell #33

wants to merge 9 commits into from

Conversation

jstclair
Copy link
Collaborator

I've replaced the make.js system for build, minification, linting, and test with a gulp-based system. As far as I can tell, the output is pretty much the same; I did manage to add support for sourcemaps for the minified version of editableCell.

Looking for some feedback -

  • Is this worth merging?
  • Any comments/fixes?
  • Next steps? I've been using a combination of gulp-bump (version/tagging), gulp-git and gulp-gh-pages in a different project to package up the entire release process into a simple gulp bump --minor && gulp release

@jstclair
Copy link
Collaborator Author

Ping @gnab

@gnab
Copy link
Owner

gnab commented Feb 26, 2015

I like it :) 👍

@gnab
Copy link
Owner

gnab commented Feb 26, 2015

That is, I'm pro merging, have no comments to the diffs which look fine, and I also think streamlining the release process sounds interesting.

@jstclair
Copy link
Collaborator Author

Not 100% sure of the correctness of the Add release task, since it:

  • Assumes you're publishing from master
  • Would actually have an effect (if it's not correct, we'd have to manually fix the release for Bower)

But that's the general idea!

You would do the following:

gulp release # normal 'patch bump (i.e., v2.1.2 to v2.1.3
gulp release --inc 'minor' # minor bump (i.e., v2.1.2 to v.2.2.0)
gulp release --inc 'major' # v2.1.2 to v3.0.0

You can also test out (but it will leave your local repo is a weird state):

gulp release --dry-run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants