update deposit amount out calculation in reader

gmx-io · Jun 17, 2024 · ca7d92b · ca7d92b
1 parent 0694543
commit ca7d92b
Showing 1 changed file with 16 additions and 3 deletions.
diff --git a/contracts/reader/ReaderDepositUtils.sol b/contracts/reader/ReaderDepositUtils.sol
@@ -121,6 +121,7 @@ library ReaderDepositUtils {
         );
 
         uint256 mintAmount;
+        uint256 amountIn = fees.amountAfterFees;
 
         MarketPoolValueInfo.Props memory poolValueInfo = MarketUtils.getPoolValueInfo(
             params.dataStore,
@@ -149,7 +150,7 @@ library ReaderDepositUtils {
         }
 
         if (params.priceImpactUsd > 0) {
-            (int256 positiveImpactAmount, /* uint256 cappedDiffUsd */) = MarketUtils.getSwapImpactAmountWithCap(
+            (int256 positiveImpactAmount, uint256 cappedDiffUsd) = MarketUtils.getSwapImpactAmountWithCap(
                 params.dataStore,
                 params.market.marketToken,
                 params.tokenOut,
@@ -162,6 +163,18 @@ library ReaderDepositUtils {
                 poolValue,
                 marketTokensSupply
             );
+
+            if (cappedDiffUsd != 0) {
+                (int256 tokenInPriceImpactAmount, /* uint256 cappedDiffUsd */) = MarketUtils.getSwapImpactAmountWithCap(
+                    params.dataStore,
+                    params.market.marketToken,
+                    params.tokenIn,
+                    params.tokenInPrice,
+                    cappedDiffUsd.toInt256()
+                );
+
+                amountIn += tokenInPriceImpactAmount.toUint256();
+            }
         }
 
         if (params.priceImpactUsd < 0) {
@@ -173,11 +186,11 @@ library ReaderDepositUtils {
                 params.priceImpactUsd
             );
 
-            fees.amountAfterFees -= (-negativeImpactAmount).toUint256();
+            amountIn -= (-negativeImpactAmount).toUint256();
         }
 
         mintAmount += MarketUtils.usdToMarketTokenAmount(
-            fees.amountAfterFees * params.tokenInPrice.min,
+            amountIn * params.tokenInPrice.min,
             poolValue,
             marketTokensSupply
         );