Cli interface not properly using scheme and api-port arguments#127
Open
gCarlNoiseux wants to merge 2 commits intogmr:masterfrom
Open
Cli interface not properly using scheme and api-port arguments#127gCarlNoiseux wants to merge 2 commits intogmr:masterfrom
gCarlNoiseux wants to merge 2 commits intogmr:masterfrom
Conversation
…ents that do not match with the __init__ declaration of the class, resulting host parameter being used for addr, port for host and scheme for token. Using keyword arguments instead solves the issue and makes it more robust to function definition changes.
gCarlNoiseux
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instanciation of Consul instance in cli.py file uses positional arguments that do not match with the init declaration of the class, resulting in host parameter being used for addr, port for host and scheme for token.
Using keyword arguments instead solves the issue and makes it more robust to function definition changes down the line.