-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid double messaging on subset creation #2515
base: main
Are you sure you want to change the base?
Conversation
… followed by an update message, instead just broadcast a create subset message with the correct subset state
f96f365
to
7608a6c
Compare
@dhomeier - would you like to review this? I've had confirmation from the jdaviz side that it works for them. |
Actually, maybe hold off on merging - I think we might need a small PR in Jdaviz, I'm seeing spectral extraction fail to extract when a spatial subset is created. Hopefully a quick fix on our end. |
But nothing needed on this side, is that right? |
I'm pretty sure that's correct, still investigating the fix on our end. |
@astrofrog It seems like at the point we get the
with the error
It seems like this is a timing conflict, would it be possible to send the |
The setter is already calling |
Avoid broadcasting a create subset message with an empty subset state followed by an update message, instead just broadcast a create subset message with the correct subset state