BUG: Fix layers dropdown not showing all loaded data #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
astrofrog
reviewed
Aug 12, 2021
| @@ -72,6 +72,9 @@ def _update_layers_from_glue_state(*args): | |||
| self.viewer.state.add_callback('layers', _update_layers_from_glue_state) | |||
| _update_layers_from_glue_state() | |||
There was a problem hiding this comment.
I don't fully understand why this isn't doing the trick (the add callback). Let me double check what is going on.
|
I think #251 is the preferred way of fixing this as it gets to why the callback wasn't being triggered at the right time. |
|
Superseded by #251 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a subset of #244 that only fixes a bug introduced by #249 . Hopefully this is less controversial and can get merged faster. cc @rosteen @astrofrog