Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spectrum1D round-trip test #22

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Spectrum1D round-trip test #22

wants to merge 2 commits into from

Conversation

eteq
Copy link
Collaborator

@eteq eteq commented Aug 13, 2020

This PR is currently just a (non-functional) test for round-tripping behavior in Spectrum1D. Meant as a starting point for test-driven development regarding an issue I'm about to create

@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (755874d) 96.92% compared to head (f806a8c) 96.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   96.92%   96.95%   +0.02%     
==========================================
  Files          18       18              
  Lines        1399     1411      +12     
==========================================
+ Hits         1356     1368      +12     
  Misses         43       43              
Impacted Files Coverage Δ
glue_astronomy/translators/spectrum1d.py 94.73% <100.00%> (+0.07%) ⬆️
...lue_astronomy/translators/tests/test_spectrum1d.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dhomeier
Copy link
Contributor

@eteq I have rebased this and committed my proposed solution from #23 (comment) for an initial implementation.

@astrofrog astrofrog marked this pull request as ready for review June 15, 2023 14:20
@astrofrog astrofrog marked this pull request as draft June 15, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants