Handle GWCS for specutils 2.0 compatibility #100
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
==========================================
- Coverage 96.68% 86.73% -9.96%
==========================================
Files 18 16 -2
Lines 1448 1470 +22
==========================================
- Hits 1400 1275 -125
- Misses 48 195 +147 ☔ View full report in Codecov by Sentry. |
Draft
7 tasks
pllim
reviewed
May 14, 2024
setup.cfg
Outdated
| @@ -20,7 +20,7 @@ install_requires = | |||
| astropy>=4.0 | |||
| glue-core>=1.6.1 | |||
| regions>=0.4 | |||
| specutils>=0.7 | |||
| specutils>=2.0 | |||
There was a problem hiding this comment.
This pin causes this branch refusing to install because specutils is still at 2.0.dev that is technically less than 2.0 stable.
pllim
reviewed
May 14, 2024
Co-authored-by: P. L. Lim <[email protected]>
rosteen
force-pushed
the
specutils-v2.0-compat
branch
from
f416dad
to
fe332dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding better handling of GWCS in the Spectrum1D handler. Opening as draft since this may need a couple other changes/additions, and because it shouldn't be merged until specutils 2.0 is ready for release. I'll also add some test coverage for the new code.