Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 envs and newer PyQt6 + PySide6 configurations to CI #41

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

dhomeier
Copy link
Contributor

@dhomeier dhomeier commented Sep 9, 2024

Description

Addressing #40 and bringing in some newer Qt6 configurations up to 6.7, matching a bit closer the glue-qt setup; additionally following up on #38 testing without any qtpy in the CI as well (13 fewer tests).
This also fixes failures as in #39, due to a QtPy6 mismatch with the latest version of QtPy6-Qt6 installed by default.

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.70%. Comparing base (a9a5e79) to head (d4d9d2f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
+ Coverage   96.35%   96.70%   +0.35%     
==========================================
  Files          18       18              
  Lines        2274     2274              
==========================================
+ Hits         2191     2199       +8     
+ Misses         83       75       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhomeier dhomeier added the no-changelog-entry-needed Skipped in automated Changelog generation label Sep 9, 2024
Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dhomeier
Copy link
Contributor Author

Just rerunning CI to make sure this is not affected by glue-viz/glue-qt#24

@dhomeier dhomeier merged commit afe8097 into glue-viz:main Sep 12, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed Skipped in automated Changelog generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants